parse global enums #1387
parse global enums #1387
Conversation
Codecov ReportBase: 95.71% // Head: 95.55% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1387 +/- ##
==========================================
- Coverage 95.71% 95.55% -0.17%
==========================================
Files 14 16 +2
Lines 2826 2994 +168
==========================================
+ Hits 2705 2861 +156
- Misses 66 74 +8
- Partials 55 59 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| return value | ||
| } | ||
| return cv.Value | ||
| } |
There was a problem hiding this comment.
The behavior of this function is quite unusual. it value is an ast.Expresion , it populates the ConstVariable type and value , otherwise, it returns a value that may be ni ?
There was a problem hiding this comment.
cv.Value is initialized in the func collectConstVariables with a ast.Expr, and then will be reassigned with the evaluated non-nil value of integer or string type，so it would never be nil.
* enhancement: evaluate const across packages
Describe the PR
if a global custom type is defined based on an underlying integer or string type, it will be considered as an enum type.
an enum type exists with two extensions:
x-enum-varnames: record their names
x-enum-comments: record their comments associated to their names.
Relation issue
#1367