fix: Generics not detected if name does not contain a pkg name #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generic detection moved to own method - prepend pkg path if not provided refs swaggo#1319
Codecov ReportBase: 95.63% // Head: 95.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1328 +/- ##
=======================================
Coverage 95.63% 95.64%
=======================================
Files 14 14
Lines 2865 2871 +6
=======================================
+ Hits 2740 2746 +6
Misses 70 70
Partials 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
FabianMartin
changed the title
|
@ubogdan if you can please review this PR and include this fix in the |
|
@FabianMartin Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Fixes bug described in #1319
Relation issue
#1319
Additional context
Tested with Go 1.15, 1.16, 1.17, 1.18 and 1.19.