fix: Generic Fields does not handle Arrays in the .swaggo file #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Detect array type and transform schema into spec.ArrayProperty if needed fixes swaggo#1318, swaggo#1320
Codecov Report
@@ Coverage Diff @@
## master #1322 +/- ##
=======================================
Coverage 95.63% 95.63%
=======================================
Files 14 14
Lines 2863 2865 +2
=======================================
+ Hits 2738 2740 +2
Misses 70 70
Partials 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
FabianMartin
force-pushed
the
override-array
branch
from
29b061f
to
64c4351
Compare
- use methods from Operation to get schema - methods parseObjectSchema and parseCombinedObjectSchema disconnected from struct
FabianMartin
force-pushed
the
override-array
branch
from
64c4351
to
c9e9d4e
Compare
|
@FabianMartin Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Fixes Bug described in #1318 and #1320
Relation issue
Additional context
Since I did not find any suitable tests, I integrated them into the generics tests.
Tested with Go 1.15, 1.16, 1.17, 1.18 and 1.19.