fix: temp dir to be the same as SerchDir to avoid invalid cross-device link (#1203) #1241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Fix temp file logic t avoid invalid cross-device link
Relation issue
#1203
Additional context
Cause
This error occurs when os.Rename between different partitions
https://groups.google.com/g/golang-dev/c/5w7Jmg_iCJQ
In other words, TMPDIR and PWD are different partitions.
When
ioutil.TempFile(dir, pattern string)
's first parameter is empty string, TempFile are created on TMPDIR.Solution
Fix
filepath.Split()
tofilepath.Dir() and Base()
.filepath.Split
may return an empty string.Check