add --quiet=true for swag init, make the debug logger quiet. #1206
Conversation
cmd/swag/main.go
Outdated
| @@ -29,9 +30,14 @@ const ( | |||
| parseDepthFlag = "parseDepth" | |||
| instanceNameFlag = "instanceName" | |||
| overridesFileFlag = "overridesFile" | |||
| quiet = "quiet" | |||
There was a problem hiding this comment.
I prefer the q flag in favor of quiet.
If this flag disables all info output, we may use s for silent.
There was a problem hiding this comment.
I prefer the
qflag in favor ofquiet. If this flag disables all info output, we may usesfor silent.
I add a alias q, is that ok for you?
https://github.com/jixiuf/swag/blob/quiet_flag/cmd/swag/main.go#L39
Codecov Report
@@ Coverage Diff @@
## master #1206 +/- ##
==========================================
- Coverage 95.06% 94.71% -0.36%
==========================================
Files 12 11 -1
Lines 2532 2477 -55
==========================================
- Hits 2407 2346 -61
- Misses 68 71 +3
- Partials 57 60 +3
Continue to review full report at Codecov.
|
jixiuf
force-pushed
the
quiet_flag
branch
3 times, most recently
from
614a68d
to
d853924
Compare
cmd/swag/main.go
Outdated
| ) | ||
|
|
||
| var initFlags = []cli.Flag{ | ||
| &cli.BoolFlag{ | ||
| Name: quietFlag, | ||
| Aliases: []string{q}, |
There was a problem hiding this comment.
You forgot to add the quotes :)
Error: vet: cmd/swag/main.go:40:21: undeclared name: q
There was a problem hiding this comment.
Sorry for that. now done.
|
@jixiuf Thanks for your contribution. |
Describe the PR
Add a
--quiet=true flag forswag init.make the debug logger quiet.
Relation issue
#1193