-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : enum has null value, it will be shown #9683
Merged
glowcloud
merged 9 commits into
swagger-api:master
from
bejewel-kyoungmin:enum-null-value-will-be-shown
May 7, 2024
Merged
fix : enum has null value, it will be shown #9683
glowcloud
merged 9 commits into
swagger-api:master
from
bejewel-kyoungmin:enum-null-value-will-be-shown
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char0n
reviewed
May 7, 2024
char0n
reviewed
May 7, 2024
@glowcloud please make sure this renders in 2020-12 render as well. |
…nto enum-null-value-will-be-shown
Co-authored-by: Vladimír Gorej <[email protected]>
glowcloud
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
char0n
approved these changes
May 7, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in this case, in parameters, and response has enum type schema, and enum has null value.
but swagger ui doesn't show null value. it makes reader confused.
Motivation and Context
Fixes #9682
How Has This Been Tested?
I have built swagger ui with fixed version
Screenshots (if appropriate):
before | after
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests