Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci-react): add ga build step #8392

Merged
merged 2 commits into from
Feb 15, 2023
Merged

fix(ci-react): add ga build step #8392

merged 2 commits into from
Feb 15, 2023

Conversation

tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Feb 15, 2023 •
edited
Loading

Description

Add build step to build (base) SwaggerUI, so that updated build files are used.

Motivation and Context

GA to release SwaggerUI currently does not check-in latest dist files as part of the workflow.

How Has This Been Tested?

local testing to verify addition to GA workflow works.

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai merged commit 0992c32 into swagger-api:next Feb 15, 2023
swagger-bot pushed a commit that referenced this pull request Feb 15, 2023
@semantic-release-bot
chore(release): cut the 4.16.0-alpha.3 release
eba8e36 
# [4.16.0-alpha.3](v4.16.0-alpha.2...v4.16.0-alpha.3) (2023-02-15)

### Bug Fixes

* **ci-react:** add ga build step ([#8392](#8392)) ([0992c32](0992c32))
* **ci:** add ga --tag alpha for swagger-ui-react next ([#8391](#8391)) ([f3570bc](f3570bc))
@swagger-bot
Copy link
Contributor

🎉 This PR is included in version 4.16.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tim-lai @swagger-bot