Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(request-snippets): prevent scrolling errors from missing function #7941

Merged
merged 4 commits into from
Mar 24, 2022

Conversation

tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Mar 24, 2022

Description

  • Update RequestSnippets to functional component with React Hooks
  • React Hooks allows us to implement useRef and useEffect, to localize adding/removing event listeners to RequestSnippets
  • Update LiveResponse Mocha test with updated import of RequestSnippets

Sidenote: The Curl component itself is dependent on the RequestSnippets plugin. This PR makes no changes to restore the Curl component to be free from the plugin dependency.

Motivation and Context

Fixes #7932
Followup to #7497 , where we still want to leverage useRef

Root cause is that #7497 removed the preventYScrollingBeyondElement from parent class, so this PR removes any additional references

How Has This Been Tested?

all existing tests pass.
local testing to confirm console.errors no longer appear

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai changed the title Fix/7932 scrollwheel fix(request-snippets): prevent scrolling errors from missing function Mar 24, 2022
@tim-lai tim-lai merged commit 9250e20 into swagger-api:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant