Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove clipboard inline svg from a file with Sass #6148

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Jun 16, 2020

  • directly load data:image/svg+xml
  • current webpack config only allows inline file via jsx

Description

use background: url(data:image/svg+xml...) instead of background: url (../pathTo/file.svg)

Motivation and Context

#5278 introduced a clipboard image as svg. However, currently our webpack build does not support inline image from a file in Sass.

How Has This Been Tested?

npm run build now succeeds

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

* directly load data:image/svg+xml
* current webpack config only allows inline file via jsx
@tim-lai tim-lai merged commit eeb0b73 into swagger-api:master Jun 16, 2020
mattyb678 pushed a commit to mattyb678/swagger-ui that referenced this pull request Jun 24, 2020
)

* directly load data:image/svg+xml
* current webpack config only allows inline file via jsx
@rehevkor5
Copy link

currently our webpack build does not support inline image from a file in Sass

Another good reason to avoid inline images is because they make it much harder to create a good Content Security Policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants