Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React warning related to "true" used as boolean #5497

Merged
merged 2 commits into from
Aug 23, 2019

Commits on Jul 24, 2019

  1. Fix React warning related to "true" used as boolean

    This should fix this warning seen in the console when using `swagger-ui-react`:
    
    ```
    Warning: Received the string `true` for the boolean attribute `readOnly`. Although this works, it will not work as expected if you pass the string "false". Did you mean readOnly={true}?
        in textarea (created by Curl)
        in div (created by Curl)
        in div (created by Curl)
        in Curl (created by LiveResponse)
        in div (created by LiveResponse)
        in LiveResponse (created by Responses)
    ```
    
    I did not test this change because it's trivial and there is no behavioural change here, React treats non-empty string attributes as `true`.
    silverwind committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    f01d6dd View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2019

  1. Configuration menu
    Copy the full SHA
    c681699 View commit details
    Browse the repository at this point in the history