Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove unknown props #5372

Merged
merged 11 commits into from
May 28, 2019

Conversation

Rody-Kirwan
Copy link
Contributor

@Rody-Kirwan Rody-Kirwan commented May 24, 2019

Filter unknown props applied to button element

Description

Fixes an issue introduced to facelift branch where unknown props "mod" and "unstyled" are applied to native html button. This will throw a react warning in develop.

Motivation and Context

Fixes a react warning visible in dev

How Has This Been Tested?

Error is no longer thrown in the browser console

npm run test

Screenshots (if appropriate):

Screen Shot 2019-05-24 at 13 46 34

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@Rody-Kirwan Rody-Kirwan changed the base branch from master to facelift May 24, 2019 12:47
@shockey shockey merged commit 6eefeed into swagger-api:facelift May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants