Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the withCredentials configuration key #5149

Merged
merged 10 commits into from
Mar 20, 2019
Merged

Add the withCredentials configuration key #5149

merged 10 commits into from
Mar 20, 2019

Commits on Jan 31, 2019

  1. Add the withCredentials configuration key 

    It enables passing credentials in CORS requests. e.g. Cookies and
Authorization headers.
    @segevfiner
    segevfiner committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    26d3d78 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2019

  1. Improve withCredentials documentation

    @segevfiner
    segevfiner committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    202afb5 View commit details
    Browse the repository at this point in the history

  2. Add unit tests for the withCredentials config

    @segevfiner
    segevfiner committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    9fb9fda View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. Update configuration.md

    @shockey
    shockey authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    6148528 View commit details
    Browse the repository at this point in the history

  2. Update configuration.md

    @shockey
    shockey authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    e94e066 View commit details
    Browse the repository at this point in the history

  3. only set withCredentials Fetch flag if the config value is truthy 

    there are some workarounds in the wild today that involve setting `withCredentials` on `system.fn.fetch` directly. 

this approach avoids mangling those existing workarounds!
    @shockey
    shockey authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    c7d44e4 View commit details
    Browse the repository at this point in the history

  4. add more test cases

    @shockey
    shockey authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    89e456d View commit details
    Browse the repository at this point in the history

  5. Update configs-wrap-actions.js

    @shockey
    shockey authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    c403ec5 View commit details
    Browse the repository at this point in the history

  6. Update index.js

    @shockey
    shockey authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    1df391b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into ft/2895-with-credentials-config

    @shockey
    shockey authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    8198a9e View commit details
    Browse the repository at this point in the history