Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #4431

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Fixed typo #4431

merged 1 commit into from
Apr 12, 2018

Conversation

cbo100
Copy link
Contributor

@cbo100 cbo100 commented Apr 11, 2018

Operations is lowercase, without this fix the example doesn't work as a Copy/Paste

Description

Just adjusted the code sample to make it work as-is

Motivation and Context

It allows somebody to read the documentation and use the example as a working example.

How Has This Been Tested?

I've used the modified code sample with success.

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Operations is lowercase, without this fix the example doesn't work as a Copy/Paste
@webron webron requested a review from shockey April 12, 2018 09:25
@shockey shockey added this to the April 13, 2018 milestone Apr 12, 2018
Copy link
Contributor

@shockey shockey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @cbo100!

For context: #3393 is open, to make component names case-insensitive. There was a PR for it (#3419), which stored all components internally as lower-case, and then downcased all component lookups - but the contributor withdrew the code 😢

@shockey shockey merged commit 2bf2167 into swagger-api:master Apr 12, 2018
@shockey
Copy link
Contributor

shockey commented Apr 20, 2018

Reposting my approval note so GitHub links the relevant tickets:

For context: #3393 is open, to make component names case-insensitive. There was a PR for it (#3419), which stored all components internally as lower-case, and then downcased all component lookups - but the contributor withdrew the code 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants