Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/auth operation btn error #3870

Merged
merged 9 commits into from
Nov 7, 2017
Merged

Bug/auth operation btn error #3870

merged 9 commits into from
Nov 7, 2017

Conversation

shockey
Copy link
Contributor

@shockey shockey commented Nov 7, 2017

Description

  • Makes the AuthorizeOperationBtn component dumber
  • Creates definitionsForRequirements auth selector
  • Adds NYC test coverage reporter (free bonus)

Motivation and Context

Fixes an issue identified by @webron today - no ticket for the problem.

How Has This Been Tested?

Manual
  • I tested the changes with the Swagger 2.0 Petstore.
  • I tested the changes with the OpenAPI 3.0 Petstore.
  • I tested the changes with an OpenAPI 3.0 document with a multiflow OAuth2 security scheme.
Project tests
  • I added Swagger 2.0 tests for the selectors I changed.
  • OAS 3.0 is already covered by existing tests.

Screenshots (if appropriate):

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shockey shockey force-pushed the bug/auth-operation-btn-error branch from a0db553 to cfc030d Compare November 7, 2017 05:13
@shockey shockey merged commit 076f32b into master Nov 7, 2017
@shockey shockey deleted the bug/auth-operation-btn-error branch November 7, 2017 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant