Add validateMaximum & validateMinimum #3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This address some of the validation requested on Issue #993
owenconti
reviewed
Sep 24, 2017
src/core/utils.js
Outdated
| if (err) errors.push(err) | ||
| } | ||
|
|
||
| if (minimum) { |
There was a problem hiding this comment.
Will this handle negative minimum values?
There was a problem hiding this comment.
Sure it will, what makes you think it won't?
There was a problem hiding this comment.
I thought for a second that negative integers would evaluate as false, but I was wrong. The only number that does is 0.
There was a problem hiding this comment.
Thanks for adding the test to verify!
Testing valid negative number with min and max
shockey
suggested changes
Sep 28, 2017
shockey
approved these changes
Sep 29, 2017
|
Thanks @heldersepu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address some of the validation requested on Issue #993