-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAS3 multi examples in requestbody #3616
OAS3 multi examples in requestbody #3616
Conversation
very basic support for multi examples in OAS3 requestBody , `externalValue` is not supported yet.
for further operations
also adjust style of example title
…as3/multi-examples-in-requestBody
in case of an example provides inline `value` property, as an object
using OAS3 spec attached here |
The rendering of |
@biggates thanks for the contribution and sorry for the delayed response. I'd like to take a bit of a closer look into the implementation. This is not exactly what I had in mind for implementing it, though it's definitely a needed solution. Would you be open to change it based on feedback and also apply the same behavior to responses and regular parameters? |
@webron Sure, I'm glad to contribute on this. |
…as3/multi-examples-in-requestBody
So this branch will work with 3.2.2
…as3/multi-examples-in-requestBody
@webron, bump 😄 |
TODO: `externalValue`
…as3/multi-examples-in-requestBody
@shockey I'm still working on this, the current progress looks like this: using the definition https://gist.github.com/biggates/4955d608379a8b1b3224e815c7dd0dc9 I'm not sure whether this is what you have in mind, so I still keep the examples in response as my previous implmentation. Also the examples in parameters is not finished yet. Maybe I should close this PR for now and re-open one later? |
…as3/multi-examples-in-requestBody # Conflicts: # src/core/plugins/oas3/components/index.js
…as3/multi-examples-in-requestBody
Added support for parameter examples in OAS3. Known Issues: * In "Try It Out" mode, all example tabs are redered as "active" and their values are all displayed
Oops, this breaks RequestBodyEditor. 😭 |
manually merged some changes from remote/master. Known issues: * parameter example default value is missing * response example value is not correct
…as3/multi-examples-in-requestBody
@biggates is it possible to rebase it to the master and merge in near future? |
Merged from swagger-api#3616, then collected and re-applied the diff to have a nice git history
Closing in favor of #4092. |
Merged from swagger-api#3616, then collected and re-applied the diff to have a nice git history
This provides multiple examples in OAS3 examples in requestBody.