Pass swagger options to swagger-js Operation#execute method #1112
Conversation
| @@ -313,7 +313,7 @@ SwaggerUi.Views.OperationView = Backbone.View.extend({ | |||
| if (isFileUpload) { | |||
| return this.handleFileUpload(map, form); | |||
| } else { | |||
| return this.model['do'](map, opts, this.showCompleteStatus, this.showErrorStatus, this); | |||
| return this.model.execute(map, this.options.swaggerOptions, this.showCompleteStatus, this.showErrorStatus); | |||
There was a problem hiding this comment.
From what I can tell, this.options is undefined and should be this.opts (src/main/javascript/view/OperationView.js#L16). Also, should you change this.options.swaggerOptions to this.options.swaggerOptions || {} just to be safe?
There was a problem hiding this comment.
This object OperationView is created here: https://github.com/swagger-api/swagger-ui/blob/develop_2.0/src/main/javascript/view/ResourceView.js#L52-L59
Basically, this.options is Backbone.js stuff that gets passed around. Good idea to add the guard to empty {}.
There was a problem hiding this comment.
Yeah, same pattern is used few lines later in the code: https://github.com/swagger-api/swagger-ui/blob/develop_2.0/src/main/javascript/view/OperationView.js#L649
swagger-api/swagger-ui/swagger-api#1112
Pass swagger options to swagger-js Operation#execute method
Pass swagger options to swagger-js Operation#execute method
As in subject,
Operation#executefrom swagger-js expectsswaggerOptionsby the look of this code: https://github.com/swagger-api/swagger-js/blob/develop_2.0/lib/types/operation.js#L542-L544 and swagger-js tests.