Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Config option source #9818

Closed
char0n opened this issue Apr 15, 2024 · 1 comment
Closed

URL Config option source #9818

char0n opened this issue Apr 15, 2024 · 1 comment

Comments

@char0n
Copy link
Member

char0n commented Apr 15, 2024

After we receive config options from remote URL we are merging it in the following way:

 mergedOptions = mergeOptions({}, systemOptions, mergedOptions, urlOptions, queryOptions)

Given that the order of config options source precedence is:

  1. query options
  2. url options
  3. user options
  4. system options

...we should probably merge it in the following way:

mergedOptions = mergeOptions({}, defaultOptions, systemOptions, userOptions, urlOptions, queryOptions)

Reasoning

In the original mergedOptions the systemOptions are fully overridden by defaultOptions which are part of mergeOptions. We don't want to do that. We want systemOptiosn, urlOptions and queryOptions to kick in.

@char0n
Copy link
Member Author

char0n commented Apr 17, 2024

Addressed by #9831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants