Issue with: exclusiveMaximum/exclusiveMinimum

[zbuh]

• OS: macOS
• Browser: FireFox
• Method of installation: fastapi 0.100
• Swagger/OpenAPI version: OpenAPI 3.1]

example schema:

{
    "components": {
        "schemas": {
            "HTTPValidationError": {
                "properties": {
                    "detail": {
                        "items": {
                            "$ref": "#/components/schemas/ValidationError"
                        },
                        "title": "Detail",
                        "type": "array"
                    }
                },
                "title": "HTTPValidationError",
                "type": "object"
            },
            "Location": {
                "properties": {
                    "lat": {
                        "exclusiveMaximum": 90.0,
                        "exclusiveMinimum": -90.0,
                        "title": "Lat",
                        "type": "number"
                    },
                    "lng": {
                        "maximum": 180.0,
                        "minimum": -180.0,
                        "title": "Lng",
                        "type": "number"
                    }
                },
                "required": [
                    "lat",
                    "lng"
                ],
                "title": "Location",
                "type": "object"
            },
            "ValidationError": {
                "properties": {
                    "loc": {
                        "items": {
                            "anyOf": [
                                {
                                    "type": "string"
                                },
                                {
                                    "type": "integer"
                                }
                            ]
                        },
                        "title": "Location",
                        "type": "array"
                    },
                    "msg": {
                        "title": "Message",
                        "type": "string"
                    },
                    "type": {
                        "title": "Error Type",
                        "type": "string"
                    }
                },
                "required": [
                    "loc",
                    "msg",
                    "type"
                ],
                "title": "ValidationError",
                "type": "object"
            }
        }
    },
    "info": {
        "title": "FastAPI",
        "version": "0.1.0"
    },
    "openapi": "3.1.0",
    "paths": {
        "/location": {
            "post": {
                "operationId": "create_location_location_post",
                "requestBody": {
                    "content": {
                        "application/json": {
                            "schema": {
                                "$ref": "#/components/schemas/Location"
                            }
                        }
                    },
                    "required": true
                },
                "responses": {
                    "200": {
                        "content": {
                            "application/json": {
                                "schema": {}
                            }
                        },
                        "description": "Successful Response"
                    },
                    "422": {
                        "content": {
                            "application/json": {
                                "schema": {
                                    "$ref": "#/components/schemas/HTTPValidationError"
                                }
                            }
                        },
                        "description": "Validation Error"
                    }
                },
                "summary": "Create Location"
            }
        }
    }
}

Generated:

Originally reported in: fastapi/fastapi#9709 (comment)

[char0n]

Hi @zbuh,

Looks legit, investigating...

[char0n]

@zbuh,

What actually seems to be the issue?

maximum and minimum keywords have following definition in JSON Schema 2020-12:

So the visual representation of the following keywords is correctly [-180, 180] which represents fully inclusive range.

"maximum": 180.0,
"minimum": -180.0,
"title": "Lng",
"type": "number"

More info in: https://json-schema.org/draft/2020-12/json-schema-validation.html#section-6.2

[Kludex]

The issue is on exclusiveMaximum and exclusiveMinimum, not on minimum and maximum (as the title mentions).

It should show (-90, 90) for exclusive*, and [-180, 180] for the non-exclusive ones (the latter is fine).

You can check the same link you provided, it's on the same section. You can also check how ReDoc renders it. 👀

[zbuh]

Yes, the issue is with exclusive*, seems that schema validation and documentation are not coherent.

[char0n]

Ahh OK, because the image in issue description and the fastapi/fastapi#9709 (comment) deals with lng.

[Kludex]

Ahh OK, because the image in issue description and the tiangolo/fastapi#9709 (comment) deals with lng.

@zbuh mentions that there's an inconsistency. They don't say anything about lng...

Anyway, do you need anything else from us here?

[char0n]

Nope, thanks! I identified the bug and working on the bugfix

[Kludex]

Nope, thanks! I identified the bug and working on the bugfix

Thanks! 🙏

[char0n]

Addressed in #9030. Will be part of next SwaggerUI release.

[Kludex]

@char0n It will render the above as (-90, 90), and not [-90, 90], right?

[zbuh]

shouldnt it be rendered as ]-90, 90[ ?

[Kludex]

]-90, 90[

Both notations are equivalent: https://en.wikipedia.org/wiki/Interval_(mathematics)

Either () or ][ are fine.

[char0n]

@Kludex

---

@zhub - could be but we use the more generally recognized notations:

[zbuh]

got it. thanks!

[Kludex]

Cute! Thanks! 🙏

[char0n]

Another thing I've notice is that I forgot to handle integer type:

openapi: 3.1.0
info:
  version: 1.2.3
  title: title
components: 
  schemas:
    Location:
      properties:
        lat:
          type: integer

results in

---

Addressed in #9031