Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Response Code to Response Class and Response Message Section #640

Closed
edmondchui opened this issue Oct 2, 2014 · 9 comments
Closed

Add Response Code to Response Class and Response Message Section #640

edmondchui opened this issue Oct 2, 2014 · 9 comments
Labels
swagger-js type: feature
Milestone
v2.1

Comments

@edmondchui
Copy link
Contributor

With respect to the fix for #637, we need to show the response code (20x) in the Response Class and Response Message section so that the API users know what is the response code to expect. Before that issue the response code was always 200.
@fehguy fehguy added this to the v2.1.0-M1 milestone Dec 30, 2014
fehguy added a commit that referenced this issue Feb 1, 2015
@fehguy
fix for #640
3ef263d
@fehguy fehguy closed this as completed Feb 1, 2015
@edmondchui
Copy link
Contributor Author

Thx. When will it be merged to master?

@fehguy
Copy link
Contributor

fehguy commented Feb 2, 2015

it has been as of this morning. Give it a whirl and reopen if you see issues.

@edmondchui
Copy link
Contributor Author

Reopen this issue as the response for 201 or 204 is not shown under the Response Class section. Only 200 works.

@edmondchui
Copy link
Contributor Author

BTW, how do I reopen? I don't see the button for reopen.

@webron
Copy link
Contributor

webron commented Feb 2, 2015

Reopened it for you.

@webron webron reopened this Feb 2, 2015
@edmondchui
Copy link
Contributor Author

Thanks Ron.

@fehguy fehguy modified the milestones: v2.1.0-M2, v2.1-M1 Feb 3, 2015
mjumbewu pushed a commit to mjumbewu/swagger-ui that referenced this issue Mar 7, 2015
@fehguy
fix for swagger-api#640
69723b4
@fehguy
Copy link
Contributor

fehguy commented Mar 26, 2015

we should be rendering the lowest 2xx response for the top response method, or default if not present.

@fehguy fehguy modified the milestones: v2.1, v2.1-M2 Mar 26, 2015
@mohsen1
Copy link
Contributor

mohsen1 commented Mar 26, 2015

waiting for swagger-api/swagger-js#325

@fehguy fehguy mentioned this issue May 8, 2015
Closed
@fehguy
Copy link
Contributor

fehguy commented May 8, 2015

added reference to parent issue

@fehguy fehguy closed this as completed May 8, 2015
Jonahss pushed a commit to eaze/swagger-ui that referenced this issue Aug 12, 2016
@fehguy
fix for swagger-api#640
016a9ad
vincent-zurczak pushed a commit to roboconf/swagger-ui that referenced this issue Aug 18, 2016
@fehguy
fix for swagger-api#640
a9c2b91
JuanSW18 pushed a commit to Digital-Paw/digital-paw-swagger-ui that referenced this issue Aug 23, 2024
@fehguy
fix for swagger-api#640
5ea2860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
swagger-js type: feature
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
4 participants
@webron @fehguy @mohsen1 @edmondchui