Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate CSS #3329

Closed
heldersepu opened this issue Jul 3, 2017 · 3 comments · Fixed by #3352
Closed

Duplicate CSS #3329

heldersepu opened this issue Jul 3, 2017 · 3 comments · Fixed by #3352
Assignees
@shockey
Labels
locked-by: lock-bot P2 type: bug version: 3.x

Comments

@heldersepu
Copy link
Contributor

heldersepu commented Jul 3, 2017 •
edited
Loading

I'm in the process of updating Swashbuckle with swagger-ui 3.x an I noticed that the CSS for the input.download-url-input shows duplicate style in the developer tools, it seems one is from a <style> in the body and the other from the .css file.

image
@shockey
Copy link
Contributor

shockey commented Jul 6, 2017

Confirmed. At first look, it appears that style-loader and extract-text-webpack-plugin are doing double duty, so the styles get packed into the bundle and included as a standalone file.

@shockey shockey added the Ready label Jul 6, 2017
@owenconti owenconti mentioned this issue Jul 8, 2017
Merged
shockey added a commit that referenced this issue Jul 18, 2017
@shockey
Merge pull request #3352 from owenconti/bug/3329-duplicate-css
7b5a327 
Fixes #3329 - Fix duplicate CSS in production builds
@heldersepu
Copy link
Contributor Author

Awesome! will test it out after you guys do the Rebuild dist

@heldersepu
Copy link
Contributor Author

Awesome! it works as intended with 3.0.20 !

@lock lock bot unassigned Minasokoni Jul 3, 2019
@lock lock bot locked and limited conversation to collaborators Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shockey shockey

Labels
locked-by: lock-bot P2 type: bug version: 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3329 - Fix duplicate CSS in production builds
5 participants
@webron @heldersepu @shockey @owenconti @Minasokoni