-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWG-7516 utilizing safeURLResolver in swagger-parser-v3 #1911
Merged
MiloszTarka
merged 7 commits into
master
from
SWG-7516-utilizing-safe-url-resolving-in-swagger-parser
Apr 24, 2023
Merged
SWG-7516 utilizing safeURLResolver in swagger-parser-v3 #1911
MiloszTarka
merged 7 commits into
master
from
SWG-7516-utilizing-safe-url-resolving-in-swagger-parser
Apr 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frantuma
approved these changes
Apr 18, 2023
modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/OpenAPIV3Parser.java
Outdated
Show resolved
Hide resolved
modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/OpenAPIV3Parser.java
Outdated
Show resolved
Hide resolved
gracekarina
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
CalemRoelofsSB
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job 👍
MiloszTarka
deleted the
SWG-7516-utilizing-safe-url-resolving-in-swagger-parser
branch
April 24, 2023 12:59
This was referenced May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes swagger-parser-v3 to utilizes safeUrlResolver when resolving OpenAPI 3.1 definitions.
The reason behind this change is described deeply under the following PR:
#1910
The $refs are checked in ReferenceVisitor class, in readHTTP method.