Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWG-7516 utilizing safeURLResolver in swagger-parser-v3 #1911

Merged

Conversation

MiloszTarka
Copy link
Member

@MiloszTarka MiloszTarka commented Apr 14, 2023

This PR makes swagger-parser-v3 to utilizes safeUrlResolver when resolving OpenAPI 3.1 definitions.

The reason behind this change is described deeply under the following PR:
#1910

The $refs are checked in ReferenceVisitor class, in readHTTP method.

@MiloszTarka MiloszTarka marked this pull request as ready for review April 17, 2023 08:21
Copy link
Contributor

@gracekarina gracekarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@CalemRoelofsSB CalemRoelofsSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants