swagger.js: consumes/produces vars are leaked into global namespace

[raymondfeng]

We found the following issues while troubleshooting strongloop/loopback#432.

1. Variables consumes abd produces at https://github.com/wordnik/swagger-js/blob/master/lib/swagger.js#L324 are leaked into global namespace. As a result, the logic at https://github.com/wordnik/swagger-js/blob/master/lib/swagger.js#L1236 doesn't make sense. this.operation.consumes.indexOf(consumes) === -1 will always return -1 because consumes is an array. The operation.consumes will be written into the global consumes.
2. Even worse, if the api spec doesn't specify a default consumes, the default value is [] and it throws TypeError at https://github.com/wordnik/swagger-js/blob/master/lib/shred/content.js#L112.

[fehguy]

somehow the declaration for consumes was removed. It should default to application/json I believe

[raymondfeng]

Shouldn't consumes/produces be instance vars for SwaggerResource?

I assume https://github.com/wordnik/swagger-js/blob/master/lib/swagger.js#L1191 should have its own declaration of consumes/produces too.

[fehguy]

Yes, to both. It wasn't implemented at the top-level resource for swagger.js it appears.

[fehguy]

pls reopen if you're still seeing this