Handle different types and nested structures when deserializing an example. #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fehguy anything preventing a merge here? |
|
i will try to review over next couple days |
fehguy
reviewed
Jan 24, 2017
| import io.swagger.inflector.processors.JsonExampleDeserializer; | ||
|
|
||
| @JsonDeserialize(using = JsonExampleDeserializer.class) | ||
| public class NullExample extends AbstractExample { |
There was a problem hiding this comment.
Since null is not supported in the spec, I suggest removing this one
| return new DecimalExample(node.decimalValue()); | ||
| } else if (node instanceof LongNode) { | ||
| return new LongExample(node.longValue()); | ||
| } else if (node instanceof NullNode) { |
There was a problem hiding this comment.
As with above, no support for null
| @@ -150,6 +160,12 @@ public void writeValue(JsonGenerator jgen, String field, Example o) throws IOExc | |||
| } else { | |||
| jgen.writeString(obj.getValue()); | |||
| } | |||
| } else if (o instanceof NullExample) { | |||
| " \"int\" : 42,\n" + | ||
| " \"biginteger\" : 118059162071741130342442,\n" + | ||
| " \"long\" : 1099511627776,\n" + | ||
| " \"null-key\" : null,\n" + |
| int: 42 | ||
| biginteger: 118059162071741130342442 | ||
| long: 1099511627776 | ||
| null-key: null |
|
@fehguy |
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of treating everyting under the first level in an example as a
StringExample.This will also fix so that
42will become42instead of"42".I have added
NullExampleandBigIntegerExamplefor representingnullwithout"null"and big integers.I ran into some interesting problems when I wanted to write a test for all cases.
yeswill be transformed totrue(previously"true"). This is because YAML treats it as a boolean.1180591620717411303424.42would become aDecimalExample(which stores aBigDecimalbut it ends up being transformed to adecimalalready in the first YAML step.If any of those are something that should be changed I suggest creating new issues.
This PR contains a commit from #182 in order to avoid the merge problems that would come when merging it. Please handle that one first.