Revert pointless commit to fix #2320 #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 3, 2017 13:02
null values" This reverts commit 3ad7595. This fixes issue swagger-api#2320. The original commit is pointless and dangerous, as it surprisingly overrides the behavior of SwaggerSerializers.java, but does essentially the same (but without supporting pretty printing).
This fixes issue swagger-api#2320 for YAML documents. The original code surprisingly overrides the behavior of SwaggerSerializers.java to needlessly split and join a YAML document. This was originally done to remove some kind of comment line from the YAML, but this has been removed long ago, making split/join-code pointless.
|
I've added a second commit to remove a similar issue for YAML documents, where SwaggerSerializers.java has been ignored, too. Also, I've removed some split-and-then-rejoin-code that has been pointless since ages. |
|
Is there any reason not to merge this? |
|
As discussed in related tickets (#2320, #2105, #2106) and specifically in this comment, issue with #2105 is handled by registering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "use custom object mapper to serialize json in order to avoid
null values"
This reverts commit 3ad7595.
This fixes issue #2320. The original commit is pointless and dangerous,
as it surprisingly overrides the behavior of SwaggerSerializers.java,
but does essentially the same (but without supporting pretty printing).