[swift3] fix infinite loop with inheritance and check if parent decoder exists #5416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0
branch for breaking (non-backward compatible) changes.Description of the PR
My last commit (b1a39ac) had introduced an infinite loop if you were using
discriminator
and returning a class that has a parent in one of your routes. By ensuring the instance isnil
before "going down" in the tree, we ensure that we're not already "going up", thus removing the infinite loop.Steps to reproduce
In the petstore, add a route
/cats
returningCat
elements only. It will first go through theCat
decoder, that will call theAnimal
decoder, which has a discriminator onclassName
and thus will call theCat
decoder again...