-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using typescript 2.1.4 object spread operator #4409
Using typescript 2.1.4 object spread operator #4409
Conversation
@damienpontifex thanks for the PR. Please run the following to update the Petstore samples so that CIs can verify the change.
|
Thanks @wing328 I've run the scripts and squashed the updated samples and template changes into a single commit again. |
@damienpontifex thanks but Travis reports issue with the TS Angular Petstore client and here is part of the error message:
Ref: https://s3.amazonaws.com/archive.travis-ci.org/jobs/185324798/log.txt |
…t extend function
@wing328 fixed up all the required changes in the samples and moved the sample typescript dependencies up to 2.1.4. Also moved them to use declaration files from npm to align with updated TypeScript recommendations of handling type definitions |
"tsd": "^0.6.3", | ||
"typescript": "^1.5.3" | ||
"typescript": "^2.1.4", | ||
"@types/angular": "^1.5.21" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damienpontifex If I understand correctly, the change is not backward compatible with the existing TS clients so please submit the PR against the 2.3.0
branch instead.
Closed via #4562 |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0
branch for breaking (non-backward compatible) changes.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
Resolves #4407 by replacing
extendObj
function by Typescript 2.1.4s object spread operator functionality