Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObjC] Enabled inheritance to prevent property duplication when using allOf and discriminator #3903

Merged
merged 1 commit into from
Oct 6, 2016

Conversation

AlexNolasco
Copy link
Contributor

@AlexNolasco AlexNolasco commented Sep 29, 2016

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Enabled inheritance for Objective-C to prevent property duplication when using allOf and discriminator.

@wing328 wing328 added this to the v2.2.2 milestone Oct 6, 2016
@wing328 wing328 merged commit 24b1dc8 into swagger-api:master Oct 6, 2016
@wing328
Copy link
Contributor

wing328 commented Oct 6, 2016

@AlexanderN thanks for the contribution.

@mateuszmackowiak thanks for reviewing the PR, which has been merged into the master.

@AlexNolasco AlexNolasco deleted the issue-3829 branch October 6, 2016 16:45
@wing328 wing328 changed the title Issue#3829. Objective-C client code, discriminator generated in both … [ObjC] Enabled inheritance to prevent property duplication when using allOf and discriminator Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants