Fix #12135 - Upgrading slf4j to latest #12194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Jeremy! |
|
You're welcome. I was already fighting with it and trying to figure out the problem, so I figured I'd share a solution. Here's hoping it gets reviewed and merged 🤞 |
|
thanks a lot @jeremydyoung !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
I have verified that both options of downgrading logback to 1.2.12 and upgrading slf4j to 2.0.7 solve the logging problems experienced with the cli. This PR is suggesting an upgrade to slf4j, but may technically be riskier than the logback downgrade. Fortunately the logback downgrade is similarly trivial, and could be employed as an alternative.
This has been broken since 3.0.42 on April 5, 2023, which is impacting all brew users of the swagger-codegen cli.