Merge pull request #3543 from guohuang/compile_issue2

[GO] Fixing compilation issue when pathParams is not presented
swagger-api · Aug 6, 2016 · e8095c6 · e8095c6
2 parents c220dbb + bef5c74
commit e8095c6
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 20 deletions.
diff --git a/modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/GoClientCodegen.java b/modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/GoClientCodegen.java
@@ -382,13 +382,21 @@ public Map<String, Object> postProcessOperations(Map<String, Object> objs) {
         // if the return type is not primitive, import encoding/json
         for (CodegenOperation operation : operations) {
             if(operation.returnBaseType != null && needToImport(operation.returnBaseType)) {
-                Map<String, String> customImport = new HashMap<String, String>();
-                customImport.put("import", "encoding/json");
-                imports.add(customImport);
+                imports.add(createMapping("import", "encoding/json"));
                 break; //just need to import once
             }
         }
 
+        // this will only import "strings" "fmt" if there are items in pathParams
+        for (CodegenOperation operation : operations) {
+            if(operation.pathParams != null && operation.pathParams.size() > 0) {
+                imports.add(createMapping("import", "fmt"));
+                imports.add(createMapping("import", "strings"));
+                break; //just need to import once
+            }
+        }
+
+
         // recursivly add import for mapping one type to multipe imports
         List<Map<String, String>> recursiveImports = (List<Map<String, String>>) objs.get("imports");
         if (recursiveImports == null)
@@ -400,9 +408,7 @@ public Map<String, Object> postProcessOperations(Map<String, Object> objs) {
             // if the import package happens to be found in the importMapping (key)
             // add the corresponding import package to the list
             if (importMapping.containsKey(_import)) {
-                Map<String, String> newImportMap= new HashMap<String, String>();
-                newImportMap.put("import", importMapping.get(_import));
-                listIterator.add(newImportMap);
+                listIterator.add(createMapping("import", importMapping.get(_import)));
             }
         }
 
@@ -432,9 +438,7 @@ public Map<String, Object> postProcessModels(Map<String, Object> objs) {
             // if the import package happens to be found in the importMapping (key)
             // add the corresponding import package to the list
             if (importMapping.containsKey(_import)) {
-                Map<String, String> newImportMap= new HashMap<String, String>();
-                newImportMap.put("import", importMapping.get(_import));
-                listIterator.add(newImportMap);
+                listIterator.add(createMapping("import", importMapping.get(_import)));
             }
         }
 
@@ -465,4 +469,11 @@ public String escapeQuotationMark(String input) {
     public String escapeUnsafeCharacters(String input) {
         return input.replace("*/", "*_/").replace("/*", "/_*");
     }
+
+    public Map<String, String> createMapping(String key, String value){
+        Map<String, String> customImport = new HashMap<String, String>();
+        customImport.put(key, value);
+
+        return customImport;
+    }
 }
diff --git a/modules/swagger-codegen/src/main/resources/go/api.mustache b/modules/swagger-codegen/src/main/resources/go/api.mustache
@@ -3,10 +3,8 @@ package {{packageName}}
 
 {{#operations}}
 import (
-	"strings"
-	"fmt"
 	"net/url"
-	{{#imports}}"{{import}}"
+{{#imports}}	"{{import}}"
 {{/imports}}
 )
 

diff --git a/samples/client/petstore/go/go-petstore/pet_api.go b/samples/client/petstore/go/go-petstore/pet_api.go
@@ -23,12 +23,12 @@
 package petstore
 
 import (
-	"strings"
-	"fmt"
 	"net/url"
 	"os"
-"io/ioutil"
-"encoding/json"
+	"io/ioutil"
+	"encoding/json"
+	"fmt"
+	"strings"
 )
 
 type PetApi struct {

diff --git a/samples/client/petstore/go/go-petstore/store_api.go b/samples/client/petstore/go/go-petstore/store_api.go
@@ -23,10 +23,10 @@
 package petstore
 
 import (
-	"strings"
-	"fmt"
 	"net/url"
 	"encoding/json"
+	"fmt"
+	"strings"
 )
 
 type StoreApi struct {

diff --git a/samples/client/petstore/go/go-petstore/user_api.go b/samples/client/petstore/go/go-petstore/user_api.go
@@ -23,10 +23,10 @@
 package petstore
 
 import (
-	"strings"
-	"fmt"
 	"net/url"
 	"encoding/json"
+	"fmt"
+	"strings"
 )
 
 type UserApi struct {