Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jakarta Feature #1091

Merged
merged 14 commits into from
Apr 6, 2023
Merged

Add jakarta Feature #1091

merged 14 commits into from
Apr 6, 2023

Conversation

Fyro-Ing
Copy link
Contributor

@Fyro-Ing Fyro-Ing commented Dec 26, 2022 •
edited
Loading

This is a proposition to include jakarta feature

#1054

only add jakarta Feature

upgrade spring boot3, java17 are some other features that need to be on dedicated PR

@Fyro-Ing Fyro-Ing marked this pull request as ready for review February 4, 2023 14:28
@Fyro-Ing
Copy link
Contributor Author

is there any chance to review this PR & merge for jakarta usage ?

@Fyro-Ing
Copy link
Contributor Author

@HugoMario

@HugoMario HugoMario self-assigned this Apr 5, 2023
@HugoMario HugoMario merged commit 31a85f3 into swagger-api:master Apr 6, 2023
@HugoMario
Copy link
Contributor

Thanks a lot for this PR @Fyro-Ing !!

@HugoMario HugoMario mentioned this pull request Apr 6, 2023
Closed
@VladPrudius
Copy link

Hello @HugoMario could you please clarify what is the status of this PR ?
We want to start migration to Spring boot 3, but we have blocker of swagger pluggin.

@HugoMario
Copy link
Contributor

Hi @VladPrudius
This is already merged. Let me know if you need any help.

@VladPrudius
Copy link

ah cool, as I understand it is enough just to add jakarta into additionalProperties section, correct ? I`ve already use latest version of swagger-codegen-cli:3.0.42
@HugoMario
image

@HugoMario
Copy link
Contributor

Oh, but It wll be available in next release. Meantime you can use this snapshot version

@VladPrudius
Copy link

Got it. Thank you for your time.
One more thing, do you know when will be next release ? @HugoMario

OleksandrShkurat
OleksandrShkurat reviewed May 9, 2023
View reviewed changes
src/main/java/io/swagger/codegen/v3/generators/handlebars/java/JavaHelper.java
if (withXml && jakarta) {
builder.append("import jakarta.xml.bind.annotation.*;\n");
} else if (withXml) {
builder.append("import jakarta.xml.bind.annotation.*;\n");
Copy link

@OleksandrShkurat OleksandrShkurat May 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like "import javax.xml.bind.annotation.*;\n" is expected here.
@HugoMario, Please correct me if I`m wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right
I'll try to push fix today

@Fyro-Ing Fyro-Ing mentioned this pull request May 10, 2023
Closed
@Fyro-Ing Fyro-Ing deleted the issues/1054 branch January 3, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OleksandrShkurat OleksandrShkurat OleksandrShkurat left review comments

Assignees

@HugoMario HugoMario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fyro-Ing @HugoMario @VladPrudius @OleksandrShkurat