-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ns-openapi-3-1: allow normalization refractor plugins to work on scoped ApiDOM trees #4134
Labels
Comments
char0n
added a commit
that referenced
this issue
May 23, 2024
char0n
added a commit
that referenced
this issue
May 27, 2024
glowcloud
added a commit
that referenced
this issue
May 27, 2024
glowcloud
added a commit
that referenced
this issue
May 27, 2024
glowcloud
added a commit
that referenced
this issue
May 28, 2024
glowcloud
added a commit
that referenced
this issue
May 28, 2024
glowcloud
added a commit
that referenced
this issue
May 28, 2024
char0n
pushed a commit
that referenced
this issue
May 28, 2024
glowcloud
added a commit
that referenced
this issue
May 28, 2024
char0n
pushed a commit
that referenced
this issue
May 28, 2024
glowcloud
added a commit
that referenced
this issue
May 29, 2024
char0n
pushed a commit
that referenced
this issue
May 29, 2024
All normalize refractor plugins have been made idempotent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prelude
We have an issue with normalization during partial dereference in swagger-client. How it works currently is that the undereferenced definition gets normalized and then partially dereferenced.
$$normalized
flag is set on the dereferenced structure. This means that whatever got dereferencedd during dereferencing phase, will not be normalized. This creates various side effects and inconsistencies in derefencing. End use of SwaggerUI or SwaggerClient must not expected that anything that is referenced will get normalized.More info in swagger-api/swagger-js#1396 (comment)
Optimization
Implementation aligned above will require additional traversal pass. The moment all the plugins are idempotent, we can try incorporating them into dereference traversal.
The text was updated successfully, but these errors were encountered: