Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next page keybind #180

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Next page keybind #180

merged 6 commits into from
Jan 22, 2025

Conversation

KoenDR06
Copy link
Contributor

@KoenDR06 KoenDR06 commented Jan 2, 2025

Pressing ArrowRight or ArrowDown ticks the StateMachine.
Pressing ArrowLeft or ArrowUp ticks the StateMachine back.
Pressing Space pauses the StateMachine.

Closes #127

@KoenDR06 KoenDR06 added enhancement Proposes (changes to) a feature maintainability labels Jan 2, 2025
@KoenDR06 KoenDR06 requested a review from stickyPiston January 2, 2025 15:59
@KoenDR06 KoenDR06 self-assigned this Jan 2, 2025
@KoenDR06 KoenDR06 requested review from SilasPeters and removed request for stickyPiston January 2, 2025 16:09
@KoenDR06
Copy link
Contributor Author

KoenDR06 commented Jan 2, 2025

Changed reviewer to Silas because he submitted issue.

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FINALLYYY

This is a great step, but could you also add going a state back? And, if not too difficult, pause the state machine with spacebar.

@stickyPiston
Copy link
Member

(and add the controls to the readme please ^^)

@KoenDR06 KoenDR06 requested a review from SilasPeters January 6, 2025 19:22
Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but I don't know about the previousState addition. Seems not scalable, but @stickyPiston knows this better.

src/store/state.ts Outdated Show resolved Hide resolved
@KoenDR06 KoenDR06 requested a review from SilasPeters January 21, 2025 14:07
Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you tested if it still works after removing things. Looks good to me!

Copy link
Member

@stickyPiston stickyPiston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

頑張った!

@KoenDR06 KoenDR06 merged commit 454a5f1 into master Jan 22, 2025
@KoenDR06 KoenDR06 deleted the next-keybind branch January 22, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Proposes (changes to) a feature maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next page keybind
3 participants