Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert remaining class components into function components #138

Merged
merged 41 commits into from
Oct 9, 2024

Conversation

stickyPiston
Copy link
Member

@stickyPiston stickyPiston commented Jul 6, 2024

Closes #113

Should only be merged after #140 is merged

@stickyPiston stickyPiston force-pushed the refactor/function-components branch 2 times, most recently from 8c39f6c to 51f8b13 Compare July 6, 2024 15:17
@stickyPiston stickyPiston force-pushed the refactor/function-components branch from 51f8b13 to 265deef Compare July 6, 2024 15:18
@stickyPiston stickyPiston marked this pull request as ready for review July 6, 2024 17:13
@stickyPiston stickyPiston added the blocked Can't continue developing until something is resolved label Jul 12, 2024
- Removed vite-plugin-eslint because it is not maintained anymore and
its typings are outdated
- Added types to all files and made sure the project fully type checks
it was removed in the previous commit, since it is now provided by most
browsers by default
src/components/Activities.jsx Outdated Show resolved Hide resolved
src/components/Activities.jsx Outdated Show resolved Hide resolved
src/components/Ad.jsx Outdated Show resolved Hide resolved
- installed prettier
- create simple prettier config
- upgraded eslint to v9
- installed husky and lint-staged for pre-commit hook
tooling: add formatter, upgrade eslint and create pre-commit hook
@stickyPiston stickyPiston merged commit af00c4d into master Oct 9, 2024
@stickyPiston stickyPiston deleted the refactor/function-components branch October 9, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Can't continue developing until something is resolved maintainability refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert remaining class components to function components
2 participants