Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: make overlay responsive #8

Merged
merged 7 commits into from
Nov 28, 2024
Merged

feature: make overlay responsive #8

merged 7 commits into from
Nov 28, 2024

Conversation

ArondenOuden
Copy link
Contributor

Expanding the 'near you overlay' to have a desktop version and switch to the appropriate version depending on your screen size

@ArondenOuden ArondenOuden added the enhancement New feature or request label Nov 20, 2024
SilasPeters
SilasPeters requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems adaptable and scalable! Although the code is quite repetitive, which makes it harder to maintain. Always try to define logic once, in one method, and give it parameters to make it work for different contexts.

static/css/home.css Outdated Show resolved Hide resolved
static/js/common.js Show resolved Hide resolved
static/js/nearYouOverlay.js Show resolved Hide resolved
@SilasPeters SilasPeters changed the title Feature/responsive overlay feature: responsive overlay Nov 21, 2024
@SilasPeters SilasPeters changed the title feature: responsive overlay feature: make overlay responsive Nov 21, 2024
@SamStaijen SamStaijen self-requested a review November 25, 2024 18:12
SamStaijen
SamStaijen approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@SamStaijen SamStaijen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArondenOuden ArondenOuden requested review from SilasPeters and removed request for SilasPeters November 25, 2024 18:15
@ArondenOuden ArondenOuden merged commit c2e17fd into development Nov 28, 2024
@ArondenOuden ArondenOuden deleted the feature/responsive-overlay branch November 28, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilasPeters SilasPeters SilasPeters approved these changes

@SamStaijen SamStaijen SamStaijen approved these changes

@stickyPiston stickyPiston Awaiting requested review from stickyPiston

Assignees

@ArondenOuden ArondenOuden

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArondenOuden @SamStaijen @SilasPeters