Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small console bugs #4

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Fix small console bugs #4

merged 3 commits into from
Oct 1, 2024

Conversation

ArondenOuden
Copy link
Contributor

Resolved two errors in the browser console:

  1. Error ''Cannot read property '$i' of 'undefined' ", caused by incorrectly importing dayjs
  2. An error because the Logo GET request was implemented fully. Planning on removing that feature entirely if I get permission

…lly I think all the code related to Logo requests can be removed, but I still don't know what the intended use of it was
static/js/common.js Outdated Show resolved Hide resolved
Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't quite know what the LOGO thing did, let me ask the dude who created it.

Edit: nvm I don't have his contact details

SilasPeters
SilasPeters previously approved these changes Sep 25, 2024
@SilasPeters SilasPeters changed the base branch from main to developmment September 26, 2024 15:19
@ArondenOuden ArondenOuden merged commit 0d2f85e into development Oct 1, 2024
@ArondenOuden ArondenOuden deleted the FixSmallConsoleBugs branch October 1, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants