Removed code from the old Mongoose back-end and re-organised menu's #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilasPeters
reviewed
Sep 15, 2024
|
This PR makes no changes to the database so if something breaks we can easily revert to an earlier deployment and not data will be lost. I have looked through all the pages that I know of and they seem functional (including the export of transactions) |
|
Looks good to me. @SilasPeters are there any blockers left on this PR? |
|
I am not aware of any blockers. I would say let's review, test and merge! But @stickyPiston probably has a better view on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1109. The Mongoose data will not deleted from the database with this PR and Mongoose top-ups are still shown in the transaction history and exports.