Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding updates #1121

Merged
merged 7 commits into from
Sep 3, 2024
Merged

Onboarding updates #1121

merged 7 commits into from
Sep 3, 2024

Conversation

TobiasDeBruijn
Copy link
Member

  • Change color to #61518F for emails
  • Fix instagram texts
  • Localize WhatsApp promo channel

SpookyBoy99
SpookyBoy99 reviewed Aug 28, 2024
View reviewed changes
config/locales/mailings.en.yml Outdated Show resolved Hide resolved
app/views/layouts/mailer.html.haml Show resolved Hide resolved
@TobiasDeBruijn
Fix: Incorrect activation URL
7cb1df5 
Fix: Hide 'Are you not %{name}' if there is no name
Debug: Print activation email during development (as there is no way to send emails)
Fix: Text colouring issues all over the place in authorization pages
Fix: WhatsApp promo URL is properly localised and escaped now.
SpookyBoy99
SpookyBoy99 requested changes Sep 1, 2024
View reviewed changes
app/mailers/mailings/devise.rb Outdated Show resolved Hide resolved
config/locales/mailings.en.yml Outdated Show resolved Hide resolved
config/locales/mailings.nl.yml Outdated Show resolved Hide resolved
SpookyBoy99
SpookyBoy99 previously approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@SpookyBoy99 SpookyBoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope this temporary fix will hold for today and will not be as permanent as most temporary fixes

app/mailers/mailings/devise.rb Outdated Show resolved Hide resolved
app/mailers/mailings/devise.rb Outdated Show resolved Hide resolved
This was referenced Sep 2, 2024
Closed
Closed
@SilasPeters SilasPeters linked an issue Sep 2, 2024 that may be closed by this pull request
Visibility issues with light-theme in doorkeeper #1120
Closed
@TobiasDeBruijn
Copy link
Member Author

Let's hope this temporary fix will hold for today and will not be as permanent as most temporary fixes

Unlikely. This is a weird issue in the templating or something that will need to be addressed, sooner rather than later preferably.

@TobiasDeBruijn TobiasDeBruijn mentioned this pull request Sep 2, 2024
Open
@TobiasDeBruijn TobiasDeBruijn merged commit e581f4b into master Sep 3, 2024
1 check passed
@TobiasDeBruijn TobiasDeBruijn deleted the onboarding-2 branch September 3, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpookyBoy99 SpookyBoy99 SpookyBoy99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visibility issues with light-theme in doorkeeper
2 participants
@TobiasDeBruijn @SpookyBoy99