Oh its so goddamn fast now #40
Conversation
Fix: Return correct Retry-After on ratelimit
There was a problem hiding this comment.
All bugs seem fixed. It does seem there is an issue with the rate limiter upon time(zone) changes or when the system goes into sleep mode, but this might also be a problem with governor itself. The way the image processing and rate limiter are implemented right now is suboptimal in my opinion anyway. I propose a system in which the original image will be uploaded directly to a bucket and the images will be converted on separate jobs later, of which the conversion status can be requested via an API endpoints (i.e. /jobs/photo/[id]). However, this should be done in a separate issue and the implementation in this current issue is functional and thus approved.
|
I don't think we'll ever run into either on production, so that should be OK. Further, with the way the frontend works currently, the limiter is never hit. With an S3 bucket on AWS a create request takes roughly 1.3 seconds. The conversion to other qualities is already a seperate job, only the webp conversion is 'synchronous'. I do like the job idea though, something to explore! |
No description provided.