Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple install #28

Merged
merged 3 commits into from
Aug 8, 2019
Merged

Multiple install #28

merged 3 commits into from
Aug 8, 2019

Conversation

leeluolee
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature

  • What is the related issue? (Use #issue_id to relate an open issue)

no

  • Does this PR introduce a breaking change?

no

  • Other information:

- svrx-util: add logger.spin for no-blocking spinner
- add loader to split install logic in system
- split child_process to task.js
- add testcase for multiple process installing task
@leeluolee leeluolee requested a review from xuchaoying August 8, 2019 02:41
@xuchaoying xuchaoying added the PR: enhancement :nail_care: Enhancement label Aug 8, 2019
@xuchaoying xuchaoying self-assigned this Aug 8, 2019
@xuchaoying xuchaoying merged commit ebe501a into master Aug 8, 2019
@xuchaoying xuchaoying deleted the multiple-install branch August 8, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: enhancement :nail_care: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants