Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): #18 , https not working #19

Merged
merged 2 commits into from
Jul 24, 2019
Merged

fix(core): #18 , https not working #19

merged 2 commits into from
Jul 24, 2019

Conversation

leeluolee
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the related issue? (Use #issue_id to relate an open issue)

  • Does this PR introduce a breaking change?

  • Other information:

@leeluolee leeluolee added the PR: bug fix :bug: Bug Fix label Jul 23, 2019
@leeluolee leeluolee requested a review from xuchaoying July 23, 2019 11:10
xuchaoying
xuchaoying requested changes Jul 23, 2019
View reviewed changes
packages/svrx/package.json Outdated Show resolved Hide resolved
@xuchaoying xuchaoying merged commit 4774673 into master Jul 24, 2019
@xuchaoying xuchaoying deleted the fix-https-issue-18 branch July 24, 2019 02:36
@leeluolee leeluolee mentioned this pull request Jul 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuchaoying xuchaoying xuchaoying approved these changes

Assignees
No one assigned
Labels
PR: bug fix :bug: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leeluolee @xuchaoying