Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watch(), del(), splice() to config #110

Merged
merged 6 commits into from
Oct 9, 2019
Merged

Conversation

xuchaoying
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature

  • What is the related issue? (Use #issue_id to relate an open issue)

no

  • Does this PR introduce a breaking change?

no

  • Other information:

@xuchaoying xuchaoying added the PR: new feature :rocket: New Feature label Sep 27, 2019
@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #110 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage    91.9%   91.98%   +0.08%     
==========================================
  Files          44       44              
  Lines        1568     1584      +16     
==========================================
+ Hits         1441     1457      +16     
  Misses        127      127
Impacted Files Coverage Δ
packages/svrx/lib/configure/plugin.js 100% <100%> (ø) ⬆️
packages/svrx/lib/configure/index.js 98.72% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a389f...8cff545. Read the comment docs.

@xuchaoying xuchaoying merged commit 82e171f into master Oct 9, 2019
@xuchaoying xuchaoying deleted the cy-config-model branch October 9, 2019 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: new feature :rocket: New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants