Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gasUsage topic #12

Merged
merged 16 commits into from
Jul 31, 2020
Merged

Add gasUsage topic #12

merged 16 commits into from
Jul 31, 2020

Conversation

zegerk
Copy link
Contributor

@zegerk zegerk commented Jul 25, 2020

Added the gasUsage, which is a bit different from electricity usage since the value is updated based on usage (0.0XX m3) and not the "actual" usage. Patched some code to avoid showing the gas meter value as usage when starting up - it messes up graphs

@coveralls
Copy link

coveralls commented Jul 27, 2020

Coverage Status

Coverage decreased (-2.04%) to 41.523% when pulling 1d1f6ea on zegerk:beta into af46a0d on svrooij:beta.

@svrooij
Copy link
Owner

svrooij commented Jul 27, 2020

Scrolling through the code makes me happy. Having gas usage makes this app just a little bit better! Also you are probably the first contributor next to myself.

Will accept this PR and release a new beta. Just to see if it doesn’t break my own setup.

@svrooij
Copy link
Owner

svrooij commented Jul 27, 2020

Or you still want to change things? Then I’ll just wait for a bit and merge it in one go.

@zegerk
Copy link
Contributor Author

zegerk commented Jul 28, 2020

Always happy to contribute to open-source - think one more day of gas testing and this pull request is ready to go.

@svrooij
Copy link
Owner

svrooij commented Jul 28, 2020

If you start at least one of the commit messages with fix: some description it will auto release your changes once I'll approve your PR.

@svrooij
Copy link
Owner

svrooij commented Jul 29, 2020

My gas meter only emits a new value for the gas usage every hour (60 min) exactly at the hour. So 12:00:00, 13:00:00, 14:00:00

@zegerk
Copy link
Contributor Author

zegerk commented Jul 29, 2020

Ah, the latest meters have 5m timestamps - codewise It does not matter, updated comment

@svrooij svrooij merged commit 0e6c6aa into svrooij:beta Jul 31, 2020
@github-actions
Copy link

🎉 This PR is included in version 1.6.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants