-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gasUsage topic #12
Conversation
*do not show the gas meter value on startup as gas usage increased
Scrolling through the code makes me happy. Having gas usage makes this app just a little bit better! Also you are probably the first contributor next to myself. Will accept this PR and release a new beta. Just to see if it doesn’t break my own setup. |
Or you still want to change things? Then I’ll just wait for a bit and merge it in one go. |
Always happy to contribute to open-source - think one more day of gas testing and this pull request is ready to go. |
If you start at least one of the commit messages with |
My gas meter only emits a new value for the gas usage every hour (60 min) exactly at the hour. So 12:00:00, 13:00:00, 14:00:00 |
Ah, the latest meters have 5m timestamps - codewise It does not matter, updated comment |
🎉 This PR is included in version 1.6.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Added the gasUsage, which is a bit different from electricity usage since the value is updated based on usage (0.0XX m3) and not the "actual" usage. Patched some code to avoid showing the gas meter value as usage when starting up - it messes up graphs