Switch axum Extension usage to State
#761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-gabriel
previously approved these changes
Jan 10, 2023
State is the new, type-safe way of passing around global state between handlers.
svix-andor
force-pushed
the
andor/switch-axum-extension-to-state
branch
from
2831241 to
21ce2b1
Compare
svix-gabriel
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Stateis the new, type-safe way of passing around global state between handlers in axum.Extensions were only resolved at runtime, therefore if you forgot to pass an extension withlayer()it'd only fail at runtime. WithStatea handler can't be registered on the router if its state can't pass all the required parameters to the handler.Solution
Replace all usage of
Extensionwith state.Closes #726