Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libraries to accept raw webhook secret #555

Merged
merged 29 commits into from
Jul 13, 2022
Merged

Update libraries to accept raw webhook secret #555

merged 29 commits into from
Jul 13, 2022

Conversation

svix-dylan
Copy link
Contributor

This PR updates our libraries to optionally take a raw webhook secret.

@svix-dylan svix-dylan changed the title Accept raw webhook secrets in libraries Update libraries to accept raw webhook secret Jul 12, 2022
tasn
tasn reviewed Jul 12, 2022
View reviewed changes
javascript/src/index.ts Outdated Show resolved Hide resolved
tasn
tasn reviewed Jul 12, 2022
View reviewed changes
javascript/src/index.ts Outdated Show resolved Hide resolved
tasn
tasn reviewed Jul 12, 2022
View reviewed changes
javascript/src/index.ts Outdated Show resolved Hide resolved
tasn
tasn reviewed Jul 12, 2022
View reviewed changes
javascript/src/index.ts Outdated Show resolved Hide resolved
tasn
tasn reviewed Jul 12, 2022
View reviewed changes
javascript/src/index.ts Outdated Show resolved Hide resolved
tasn
tasn reviewed Jul 12, 2022
View reviewed changes
javascript/src/index.ts Outdated Show resolved Hide resolved
tasn
tasn reviewed Jul 12, 2022
View reviewed changes
go/webhook.go Outdated Show resolved Hide resolved
tasn
tasn reviewed Jul 12, 2022
View reviewed changes
python/svix/webhooks.py Outdated Show resolved Hide resolved
tasn
tasn reviewed Jul 12, 2022
View reviewed changes
python/svix/webhooks.py Outdated Show resolved Hide resolved
@svix-dylan
Copy link
Contributor Author

@tasn js is the only lib that still supports rawString+rawBytes. All other libs now only support bytes as the only raw option, as an overload where available.

tasn
tasn reviewed Jul 13, 2022
View reviewed changes
rust/src/webhooks.rs Outdated Show resolved Hide resolved
@tasn tasn merged commit 58689c8 into svix:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasn tasn tasn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svix-dylan @tasn