Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Remove unused optional PostOptions parameters from non-POST methods #1557

Merged
merged 1 commit into from
Dec 10, 2024
Merged

rust: Remove unused optional PostOptions parameters from non-POST methods #1557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
# Changelog

## Next
*
* Libs/Rust: Remove unused optional `PostOptions` parameters from non-POST methods ([#1557])

[#1557]: https://github.com/svix/svix-webhooks/pull/1557

## Version 1.43.0
* Libs/Go: Add convenient construction of messages with pre-serialized payload ([#1538])
Expand Down
8 changes: 0 additions & 8 deletions rust/src/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,6 @@ impl<'a> Application<'a> {
&self,
app_id: String,
application_in: ApplicationIn,
_: Option<PostOptions>,
) -> Result<ApplicationOut> {
application_api::v1_period_application_period_update(
self.cfg,
Expand All @@ -328,7 +327,6 @@ impl<'a> Application<'a> {
&self,
app_id: String,
application_patch: ApplicationPatch,
_: Option<PostOptions>,
) -> Result<ApplicationOut> {
application_api::v1_period_application_period_patch(
self.cfg,
Expand Down Expand Up @@ -427,7 +425,6 @@ impl<'a> Endpoint<'a> {
app_id: String,
endpoint_id: String,
endpoint_update: EndpointUpdate,
_: Option<PostOptions>,
) -> Result<EndpointOut> {
endpoint_api::v1_period_endpoint_period_update(
self.cfg,
Expand All @@ -445,7 +442,6 @@ impl<'a> Endpoint<'a> {
app_id: String,
endpoint_id: String,
endpoint_patch: EndpointPatch,
_: Option<PostOptions>,
) -> Result<EndpointOut> {
endpoint_api::v1_period_endpoint_period_patch(
self.cfg,
Expand Down Expand Up @@ -733,7 +729,6 @@ impl<'a> Integration<'a> {
app_id: String,
integ_id: String,
integration_update: IntegrationUpdate,
_: Option<PostOptions>,
) -> Result<IntegrationOut> {
integration_api::v1_period_integration_period_update(
self.cfg,
Expand Down Expand Up @@ -843,7 +838,6 @@ impl<'a> EventType<'a> {
&self,
event_type_name: String,
event_type_update: EventTypeUpdate,
_: Option<PostOptions>,
) -> Result<EventTypeOut> {
event_type_api::v1_period_event_type_period_update(
self.cfg,
Expand All @@ -859,7 +853,6 @@ impl<'a> EventType<'a> {
&self,
event_type_name: String,
event_type_patch: EventTypePatch,
_: Option<PostOptions>,
) -> Result<EventTypeOut> {
event_type_api::v1_period_event_type_period_patch(
self.cfg,
Expand Down Expand Up @@ -1346,7 +1339,6 @@ impl<'a> OperationalWebhookEndpoint<'a> {
&self,
endpoint_id: String,
endpoint_update: OperationalWebhookEndpointUpdate,
_: Option<PostOptions>,
) -> Result<OperationalWebhookEndpointOut> {
operational_webhook_endpoint_api::update_operational_webhook_endpoint(
self.cfg,
Expand Down
1 change: 0 additions & 1 deletion rust/tests/kitchen_sink.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ async fn test_endpoint_crud() {
])),
..Default::default()
},
None,
)
.await
.unwrap();
Expand Down