Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libs/JS: Publish src to npm to make it available for source maps #1396

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

svix-lucho
Copy link
Contributor

Motivation

We export source maps with the svix javascript package, but not the corresponding source files.

Something like {"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[]..... in index.js.map throws an error since ../src/index.ts can't be found. This causes several warnings in certain bundlers.

Solution

Add the source files to the files published to npm.

Closes #1299

@svix-lucho svix-lucho marked this pull request as ready for review August 7, 2024 18:30
@svix-lucho svix-lucho requested a review from a team as a code owner August 7, 2024 18:30
@svix-lucho svix-lucho merged commit a508405 into main Aug 7, 2024
2 checks passed
@svix-lucho svix-lucho deleted the lucho/publish-js-src branch August 7, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Source Map to Package
2 participants