-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bridge: Add Kafka as an input #1333
Conversation
217a64b
to
34ce7f1
Compare
## Motivation Beta CI is failing in #1333 due to a type inference change affecting older version of the `time` crate. ## Solution Bump `Cargo.lock` by running `cargo update`. Could have only updated `time`, but I don't think it hurts to pull in other dependency updates.
25d22ea
to
0c6d136
Compare
Tests are super flaky for me locally, but looks like CI is having no such problems after updating the port to 9094... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to link the FIXMEs to actual tickets, or just drop the FIXME label if you don't think there's any concrete work to be done relating to the actual comments.
0c6d136
to
5896cd9
Compare
Created an issue for the two long FIXME's: https://github.com/svix/monorepo-private/issues/8556 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one more question/comment, but everything else seems reasonable to me.
5896cd9
to
7b55896
Compare
… that is, support converting Kafka messages into Svix API calls.
7b55896
to
762cb4a
Compare
Ready to merge from my POV, just needs an approval now! |
## What's Changed * Enable redis `tcp_nodelay` by @jaymell in #1316 * server: Simplify short-circuiting logic for Option::None by @svix-jplatte in #1318 * Improve database error classification by @svix-jplatte in #1317 * server: Remove unwraps in redis queue module by @svix-jplatte in #1319 * Improve error message by @jaymell in #1320 * Update OpenAPI spec and regenerate libs by @svix-lucho in #1321 * Add NullableBool function by @dacohen in #1322 * bridge: Upgrade omniqueue and related dependencies by @svix-jplatte in #1326 * Make config type, variant names less confusing by @svix-jplatte in #1327 * Redis updates by @jaymell in #1328 * More redis updates by @jaymell in #1329 * bridge: More config cleanup by @svix-jplatte in #1330 * Python: update deps and switch to ruff. by @tasn in #1332 * bridge: Update Cargo.lock by @svix-jplatte in #1334 * Bump locked dependencies again by @svix-jplatte in #1336 * server: Update Cargo.lock by @svix-jplatte in #1337 * build(deps): bump braces from 3.0.2 to 3.0.3 in /javascript by @dependabot in #1335 * bridge: Add Kafka as an input by @svix-jplatte in #1333 * rust: Add Svix::background_task by @svix-jplatte in #1341 * bridge: Reduce deno dependencies by @svix-jplatte in #1343 * rust: Add `Svix::with_token` to allow changing api token by @svix-aaron1011 in #1339 * build(deps): bump ws from 7.4.6 to 7.5.10 in /javascript by @dependabot in #1338 * bridge: Upgrade wiremock dev-dependency by @svix-jplatte in #1344 * bridge: Error refactoring by @svix-jplatte in #1342 * bridge: Add kafka receiver output by @svix-jplatte in #1345 * bridge: Cargo manifest cleanup by @svix-jplatte in #1346 * bridge: Remove build step from CI workflow by @svix-jplatte in #1347 * Fix `Recover Failed Webhooks` response by @jaymell in #1349 * Libs(Go): adjust Go linter by @svix-onelson in #1351 * Libs(Go): pluralize GO_MODULES in superlinter by @svix-onelson in #1353 * build(deps): bump golang.org/x/net from 0.17.0 to 0.23.0 by @dependabot in #1294 * `Recover Failed Webhooks` use configurable `until` by @jaymell in #1352 * Update comments in KafkaConsumer by @svix-jplatte in #1354 * Replace ctype_digit for PHP 8.1 deprecation of non-string arguments by @jterry in #1355 * CI: add something to run php tests by @svix-onelson in #1356 * js: Apply workaround for incomplete fetch support in Cloudflare Worker by @svix-jplatte in #1359 * Bump certifi from 2023.07.22 to 2024.7.4 in /python by @svix-jplatte in #1358 * ci: Update GitHub actions revs for php-ci by @svix-jplatte in #1360 * build(deps): bump zerovec from 0.10.2 to 0.10.4 in /server by @dependabot in #1361 * Server: bump zerovec-derive by @svix-onelson in #1362 * bridge: Add kafka to example configs, config tests by @svix-jplatte in #1357 * Libs: bump spec by @svix-onelson in #1366 ## New Contributors * @dacohen made their first contribution in #1322 * @jterry made their first contribution in #1355 **Full Changelog**: v1.24.0...v1.25.0
… that is, support converting Kafka messages into Svix API calls.
Part of https://github.com/svix/monorepo-private/issues/8508.