[Lib/JS] Compile svix package for ESM and CommonJS #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-lucho
commented
Dec 4, 2024
svix-onelson
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Will this help to surface problems like this?
#1505
I'm still hoping we can track something in CI to catch this problem the next time it creeps in.
I don't think this PR solves errors like that, because there's still a chance |
svix-lucho
added a commit
that referenced
this pull request
Dec 5, 2024
I accidentally changed the version in #1549
Merged
svix-jplatte
added a commit
that referenced
this pull request
Dec 6, 2024
## What's changed * Libs/Go: Add convenient construction of messages with pre-serialized payload ([#1538]) * Libs/Go: Reduce the use of `NullableX` types to where they actually have a use ([#1543]) * Libs/JavaScript: Add convenient construction of messages with pre-serialized payload ([#1539]) * Libs/Java: Add convenient construction of messages with pre-serialized payload ([#1544]) * Libs/C#: Bump .NET target to 8.0 ([#1546]) * Libs/C#: Add convenient construction of messages with pre-serialized payload ([#1545]) * Libs/Python: Add convenient construction of messages with pre-serialized payload ([#1540]) * Libs/Ruby: Add convenient construction of messages with pre-serialized payload ([#1541]) * Libs/JavaScript: Compile svix package for ESM and CommonJS, reducing bundle sizes ([#1549]) [#1538]: #1538 [#1543]: #1543 [#1539]: #1539 [#1540]: #1540 [#1541]: #1541 [#1544]: #1544 [#1545]: #1545 [#1546]: #1546 [#1549]: #1549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1483
Compile the svix JavaScript package in
ESMandCommonJSsimultaneously. This should solve the issues with tree-shaking (since it can only be done when the package is compiled with ESM). Also keeps the CommonJS version for backwards compatibility.Tested this locally and all the usual imports (
import { EventTypeOut } from "svix") work as expected, with no changes whatsoever.