Add 'set_ack_deadline' to Delivery, and implement for SQS/GCP #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we hide this behind a "beta" feature flag or something? |
svix-james
previously approved these changes
Jun 25, 2024
|
This looks fine to me, but let's discuss with @svix-jplatte before cutting a release. |
This allows changing the 'ack deadline' (e.g. the visibility timeout in SQS) for an existing message, which allows the consumer to spend more time processing the message before calling 'ack()'. At the moment, this is only implemented for SQS and GCP. To support this, I've added back the `QueueError::Unsupported` enum variant (which is a breaking change). This is gated behind an off-by-default 'beta' feature flag at the moment
svix-aaron1011
force-pushed
the
aaron1011/set-ack-deadline
branch
from
9f66f34
to
47ac4e7
Compare
|
I added an off-by-default |
svix-james
approved these changes
Jun 26, 2024
Looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows changing the 'ack deadline' (e.g. the visibility timeout in SQS) for an existing message, which allows the consumer to spend more time processing the message before calling 'ack()'.
At the moment, this is only implemented for SQS and GCP. To support this, I've added back the
QueueError::Unsupportedenum variant (which is a breaking change).